Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to automatically clean up after an action plugin #65509

Merged
merged 5 commits into from Dec 6, 2019
Merged

Add method to automatically clean up after an action plugin #65509

merged 5 commits into from Dec 6, 2019

Conversation

sivel
Copy link
Member

@sivel sivel commented Dec 4, 2019

SUMMARY

Add method to automatically clean up after an action plugin

By default this should automatically clean up the shell plugins tmpdir, instead of having all code paths of action plugins explicitly responsible for handling this themselves.

This should ensure that action plugins never leave behind tmp files

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
lib/ansible/plugins/action/__init__.py
ADDITIONAL INFORMATION

@sivel
Copy link
Member Author

sivel commented Dec 4, 2019

Needs:

  • tests
  • changelog

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 4, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 4, 2019
This was referenced Dec 5, 2019
Closed
Closed
@ansibot ansibot added has_issue support:community This issue/PR relates to code supported by the Ansible community. labels Dec 5, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 6, 2019
@Akasurde Akasurde mentioned this pull request Dec 6, 2019
Closed
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 6, 2019
@ansibot
Copy link
Contributor

ansibot commented Dec 6, 2019

cc @ndavison
click here for bot help

@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels Dec 6, 2019
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 6, 2019
@sivel
Copy link
Member Author

sivel commented Dec 6, 2019

Unrelated test failure. This now has tests, which I'm interested to see if we could run at the end of all integration groups. Might help us catch other issues as well.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 6, 2019
@samdoran
Copy link
Contributor

samdoran commented Dec 6, 2019

Unrelated test failure. Merging.

@samdoran samdoran merged commit 03a4edb into ansible:devel Dec 6, 2019
@Akasurde Akasurde mentioned this pull request Dec 9, 2019
Closed
sivel added a commit to sivel/ansible that referenced this pull request Dec 9, 2019
@sivel
[stable-2.9] Add method to automatically clean up after an action plu…
013d12a 
…gin (ansible#65509)

* Use correct var, move cleanup for async
* Add changelog and tests. Fixes ansible#65393. Fixes ansible#65277.
* Kill off all long running async tasks from listen_ports_facts
* Update task to work with older jinja2
(cherry picked from commit 03a4edb)

Co-authored-by: Matt Martz <matt@sivel.net>
anshulbehl pushed a commit to anshulbehl/ansible that referenced this pull request Dec 10, 2019
@sivel @anshulbehl
Add method to automatically clean up after an action plugin (ansible#…
da39b94 
…65509)

* Use correct var, move cleanup for async
* Add changelog and tests. Fixes ansible#65393. Fixes ansible#65277.
* Kill off all long running async tasks from listen_ports_facts
* Update task to work with older jinja2
@ansible ansible locked and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

@Akasurde Akasurde Awaiting requested review from Akasurde

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sivel @ansibot @samdoran